[6.1] Only show version history in FormView if version history is supported#47694
[6.1] Only show version history in FormView if version history is supported#47694joomdonation wants to merge 4 commits intojoomla:6.1-devfrom
Conversation
|
I have tested this item ✅ successfully on 609eba2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47694. |
|
Hi @joomdonation thanks for picking this up and creating the PR for it. Just tested it and it works, would suggest one small change: |
|
Thanks @Ruud68. Implemented the suggested change, also renaming the method to fit the code better. Could you please check it again? If it works, please report your test result so that the PR can be merged. Thanks |
|
I have tested this item ✅ successfully on f703205 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47694. |
|
@exlemor There was a small change after you tested the PR, so when you have a moment, please help testing it again. Thanks ! |
|
I have tested this item ✅ successfully on f703205 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47694. |
|
Thanks @exlemor for re-testing. |
|
RTC. Thanks all for feedback and testing. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47694. |
Pull Request resolves #47693.
Summary of Changes
Currently, if version history is enabled for a component, every view extends FormView class from that component will have Versions button shown, even if that view does not really support versions history. This PR just fixes that wrong behavior. The button will only be shown if:
Testing Instructions
Basically, make sure versions history still work with this PR applied. Then we will wait for @Ruud68 test confirms that it works well for his custom extension
Actual result BEFORE applying this Pull Request
Versions button is always shown for every views extends FormView class even if that view does not support versions history
Expected result AFTER applying this Pull Request
Versions button is only shown for views extends FormView class if that view support versions history
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed