feat: event-driven thread wait coordinator (BM-52) - #1
Closed
jonolee-kr wants to merge 3 commits into
Closed
Conversation
Owner
Author
|
Superseded by upstream PR get-bb#2688. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes excessive memory and request load from
bb thread wait(BM-52).(threadId, target, cursor). Identical waits share oneNotificationHubsubscription and one coalesced DB re-check. Per-caller deadlines, abort cleanup, caller limits, pino observability with anunref()ed summary timer, and a stats accessor.GET /api/v1/threads/:id/wait?status=...long-poll (404thread_not_foundfor missing threads). The existingevents/waitroute is refactored onto the coordinator with its response contract preserved.BbHttpErrorstatus 404+code not_found(route absent on older servers). The wait sleep is now abort-aware.pollIntervalMsgoverns only the fallback path.bb thread wait --output(one blocking follow returning terminal status + final output),bb thread wait-many, and lazy-loaded thread subcommands. Existing wait messages, JSON shapes, and exit codes unchanged.Measured impact
Testing
Plan, review artifacts, and demo report are attached to task BM-52.
🤖 Generated with Claude Code