Fix MQTT spam #17
Open
Fix MQTT spam #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before one had to update the list of not-running devices in the tests, after adding new devices. This had not been done recently so tests where failing. Avoid needing to do this by computing the expected-not-running devices based on the known tests devices and all configured devices
The argument definition a method is only evaluated once, at module load time, so multiple instances of States() actually shared instances of .lock and .opener Caused problems when adding some new tests for States, probably did not have any ill effects otherwise
This should avoid MQTT messages being spammed continiously in this case Fixes #14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14
Note that one can still get 1 per second when a user actively holds a button down. This should be rare enough to not be disruptive.