Fixes and improvements #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⁃ Separated the library (functions) from the testing, so functions can be tested one at a time, and so a dev can include Oauth.php in a project without having to remove test lines at the end. Simple testing page added which includes the library. ⁃ Allow author to specify their own app name instead of "jonhurlock Twitter Application-only OAuth App v.1". Because it is the author's app, they are using jonhurlock's library in their app. ⁃ Retrieve http code AFTER you make the curl request ⁃ For consistency and readability, under "get_bearer_token()", "$bearer_token" and "$base64_encoded_bearer_token" variable name changed to match other functions, and because they are not bearer tokens. ⁃ Content-length header is unnecessary, it is added automatically ⁃ adding '.""' after a variable in $headers array is unnecessary ⁃ remove "$header" variable before curl option declaration, unnecessary ⁃ "invalidate_bearer_token()" and "search_for_a_term()" return a php associative array instead of raw http data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
be tested one at a time, and so a dev can include Oauth.php in a
project without having to remove test lines at the end. Simple testing
page added which includes the library.
Twitter Application-only OAuth App v.1". Because it is the author's
app, they are using jonhurlock's library in their app.
"$bearer_token" and "$base64_encoded_bearer_token" variable name
changed to match other functions, and because they are not bearer
tokens.
associative array instead of raw http data.