Add DeclareEntrypoint #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Oct 12, 2025
Owner
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I like the concept, we just need to figure out what to do for the error type
src/error.zig
Outdated
Comment on lines
1
to
6
| pub const ProgramError = error{ | ||
| AlreadyInUse, | ||
| InvalidAccountType, | ||
| Uninitialized, | ||
| IncorrectSize, | ||
| }; |
Owner
There was a problem hiding this comment.
If you want to add these and have them work similarly to the program error in the Rust SDK, may as well just copy all the variants at https://github.com/anza-xyz/solana-sdk/blob/2d88eb491e52705ec73ee8204dc41d510c298909/program-error/src/lib.rs#L57, but that will require also setting the values individually, ie:
const ProgramError = enum(u64) {
InvalidArgument = 1 << 32,
InvalidInstructionData = 2 << 32,
};
And so on. That'll be a bit more conformant than this error type.
On the other hand, it's not a proper zig error, which makes me think we might want to omit this entirely, and allow processInstruction to return any error. What do you think?
- Change callconv(.C) to callconv(.c) in entrypoint.zig - Add direct exports in root.zig for convenience (entrypoint, PublicKey, etc.) - Fix print format in pubkey example - Add .surfpool to gitignore
- Replace Zig error type with enum(u64) matching Solana SDK values - Add all 26 builtin errors with correct bit-shifted values (n << 32) - Support custom errors in lower 32 bits - Add ProgramResult union type for cleaner error handling - Add helper methods: toU64(), custom(), getCustomCode(), toString() - Update entrypoint to use new ProcessInstruction function pointer type - Add unit tests verifying compatibility with Rust SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pub fn declareEntrypoint(comptime process_instruction: processInstruction) void ; so we can just only write processInstruction