Handle temperature==0 - #250
Merged
Merged
Conversation
Owner
|
Is there any easy way to set |
Collaborator
Author
Good catch! for cases like this we introduced training_only_params. I think if we put temperature in that set, it will be removed when playing the tournament in the training and the default of 0 will be used. I'll try it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when playing it would often pick a sub-optimal choice (e.g. probs were 0.4, 0.3 and 0.3 and it would pick 0.3). That was because it's not correclty handling the temperature. When playing, temperature is 0 which means choose the best option (randomly between them if there's more than 1 with the max value)