Skip to content

Handle temperature==0 - #250

Merged
alejandromarcu merged 1 commit into
mainfrom
temp
Jul 8, 2025
Merged

Handle temperature==0#250
alejandromarcu merged 1 commit into
mainfrom
temp

Conversation

@alejandromarcu

Copy link
Copy Markdown
Collaborator

I noticed that when playing it would often pick a sub-optimal choice (e.g. probs were 0.4, 0.3 and 0.3 and it would pick 0.3). That was because it's not correclty handling the temperature. When playing, temperature is 0 which means choose the best option (randomly between them if there's more than 1 with the max value)

@adamantivm adamantivm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alejandromarcu
alejandromarcu merged commit 6be06d7 into main Jul 8, 2025
1 check passed
@alejandromarcu
alejandromarcu deleted the temp branch July 8, 2025 21:14
@jonbinney

Copy link
Copy Markdown
Owner

Is there any easy way to set temperature=_some_number_ for training, but do the intermittent mini-tournaments with temperature=0?

@alejandromarcu

Copy link
Copy Markdown
Collaborator Author

Is there any easy way to set temperature=_some_number_ for training, but do the intermittent mini-tournaments with temperature=0?

Good catch! for cases like this we introduced training_only_params. I think if we put temperature in that set, it will be removed when playing the tournament in the training and the default of 0 will be used. I'll try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants