Syntron rfc #1
Merged
Syntron rfc #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… PRs * OMCSession.py: rename real OMCPath* classes as privat (start with '_') * OMCSession: define OMCPathDummy and OMCSessionDummy => no OMC server * OMCSession: remove OMCSessionCmd * ModelExecution.py: include all code related to model execution (from OMCsession*; ModelicaSystemCmd) * ModelicaSystemDoE.py: seperate file for this class * ModelicaSystemDoE.py: use ModelicaSystem / reduce number of arguments to __init__ * ModelicaSystem(Base).py: split getOutputs() and getContinuous() to Initial and Final data * ModelicaSystem(Base).py: getOutputs*() / getContinuous*() - always return np.float64 * ModelicaSystemBase.py: define a basic version of ModelicaSystem * ModelicaSystemRunner.py: definition of a 'runner' class using ModelicaSystemBasic / OMCSessionDummy (see PR OpenModelica#401) * test_ModelicaSystemRunner.py: test case for ModelicaSystemRunner * test_*: update of test cases based on above listed changes
This reverts commit eb312b41854b6310587e6be3cd1bed273e9197e0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
See OpenModelica#404 and OpenModelica#401
Purpose
Rebase to get draft for the Runner class.