This repository was archived by the owner on May 8, 2022. It is now read-only.
Only rewrite implied model names - #15
Open
jebw wants to merge 1 commit into
Open
Conversation
If a model name comes from the translations (ie User.class.model_name.human) or if it has been supplied by the user (options[:object_name]) then show it as is. Only rewrite underscores if it has been derived from the supplied model, i.e. error_messages_for :user
mathieujobin
reviewed
Mar 8, 2022
|
|
||
| # should space object name | ||
| assert_dom_equal %(<div class="error_explanation" id="error_explanation"><h2>2 errors prohibited this chunky bacon from being saved</h2><p>There were problems with the following fields:</p><ul><li>User email can't be empty</li><li>Author name can't be empty</li></ul></div>), error_messages_for(:user, :post, :object_name => "chunky_bacon") | ||
|
|
There was a problem hiding this comment.
Why removing a test instead of adding one ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a model name comes from the translations (ie User.class.model_name.human)
or if it has been supplied by the user (options[:object_name]) then show it
as is.
Only rewrite underscores if it has been derived from the supplied model, i.e.
error_messages_for :user