Respect retries and master timeout when task resolves #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed 2 issues for the situation where a task resolves instead of rejects and the call to `shouldContinue` returns true 1. If the `masterTimeout` time has been exceeded, it will now reject the promise. 2. It will now check if there are retries remaining and reject if there are no retries remaining or else decrement remaining retries Resolves [this issue](joeattardi#16).
Jackman3005
force-pushed
the
master
branch
2 times, most recently
from
21d769d to
0f5e52b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 2 issues for the situation where a task resolves instead of rejects and the call to
shouldContinuereturns truemasterTimeouttime has been exceeded, it will now reject the promise.retriesRemainingand reject if there are no retries remaining or else decrement remaining retriesResolves this issue.