Skip to content

Feedback#3

Open
akagomez wants to merge 2 commits intomasterfrom
gomez-feedback
Open

Feedback#3
akagomez wants to merge 2 commits intomasterfrom
gomez-feedback

Conversation

@akagomez
Copy link
Copy Markdown

This PR is not meant to be merged. It only serves as a thread for sharing/discussing my suggested changes to the guide.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this is a great explanation of can.Construct, I think it's better suited for the API docs.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like to format code strings. Not sure how that works with DocumentJS though.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure myself. I think what I was trying to say is that DocumentJS probably has a link/format for these things already.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean a format for abc? Yes DocumentJS has a style for that.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same syntax?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it uses the same markdown syntax that github supports.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I'll keep formatting them then.

@akagomez
Copy link
Copy Markdown
Author

When we incorporate this into the site, I think we should manually break on each line. The diff's will be easier to read, making it easier to maintain.

@justinbmeyer
Copy link
Copy Markdown
Collaborator

+1

Sent from my iPhone

On Mar 13, 2015, at 9:43 AM, Chris Gomez notifications@github.com wrote:

When we incorporate this into the site, I think we should manually break on each line. The diff's will be easier to read, making it easier to maintain.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants