Skip to content

Conversation

@danieldg
Copy link

@danieldg danieldg commented May 8, 2022

Fixes #20

@jnqnfe jnqnfe force-pushed the master branch 7 times, most recently from 63a467b to d0e65dd Compare January 9, 2023 07:10
@acheronfail
Copy link

acheronfail commented May 7, 2023

@danieldg while I love the idea of upstreaming this awesome tokio PulseAudio mainloop into libpulse_binding, would you be open to publishing a separate crate for others (like me!) to be able to depend on it and use it?

From my perspective - and correct me if I'm wrong @jnqnfe - this crate seems to be more of a 1:1 binding between PulseAudio's APIs rather than "a bunch of rust tools and integrations for PulseAudio". So to me, a separate crate makes sense for what is essentially "a tokio implementation of a PulseAudio mainloop".

TL;DR: I would love it if the libpulse-tokio crate added in this PR could be published to crates.io. Whether that's by upstreaming here, or by publishing it separately.

@danieldg
Copy link
Author

@acheronfail - I just published the current version of this branch. While it still has a few limitations, those can be fixed in future versions. I'd be open to adding the maintainers here to the crate if it was merged, so it could be maintained/released in lock-step.

@MaxVerevkin
Copy link

I just published the current version of this branch.

On crates.io? I couldn't find it.

@danieldg
Copy link
Author

@MaxVerevkin
Copy link

Thank you, I don't know why neither crates.io nor lib.rs could find it :(

@jnqnfe jnqnfe force-pushed the master branch 3 times, most recently from fb734ba to 4c12cd1 Compare April 18, 2025 18:42
@acheronfail
Copy link

@jnqnfe I was wondering if it'd be possible for this to be added to libpulse-binding?

I've been upgrading my dependencies, but upgrading from 2.28.2 to 2.30.1 actually means that @danieldg's libpulse-tokio breaks. 😢

Would be nice to have this all included in libpulse-binding itself. I can't remember if there was anything specific from blocking this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible tokio integration?

3 participants