Merged
Conversation
Add `generate_share_qrcode()` to Client and `share-qr` CLI command. Calls `GET /device/bind/qrcode?userId=` to generate a 5-minute sharing QR code that another Jackery user can scan to gain device access. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Raises ValueError early if user_id is empty, consistent with the existing guard in get_all_properties for device_id. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…retry test Add typed return value for generate_share_qrcode and cover the _SessionInvalidatedError → _relogin retry path that was previously untested. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I gotta tell you, it is really amazing how easy claude makes it to sniff protocols for reverse engineering. So easy, even a child (me) can do it!