Skip to content

Conversation

@iboB
Copy link
Contributor

@iboB iboB commented Sep 2, 2025

Two commits in this PR:

  • Fix potential ODR violations from the same types declared as class or struct. While it's true that the Itanium ABI, does not distinguish between the two, other ABI-s might, and MSVC's does. In rare cases this may lead to crazy bugs.
  • Fix a 32-bit shift: 1 << M is a 32-bit shift. So, even though M and buckets will be 64-bit (size_t) on a x64 system, when M is 32 or more, UB will ensue.

@iboB iboB requested a review from jll63 as a code owner September 2, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant