Skip to content

Fix opcode switch statement & long1 parsing#13

Draft
foxt wants to merge 1 commit intojlaine:masterfrom
foxt:patch-1
Draft

Fix opcode switch statement & long1 parsing#13
foxt wants to merge 1 commit intojlaine:masterfrom
foxt:patch-1

Conversation

@foxt
Copy link

@foxt foxt commented Dec 21, 2021

No description provided.

@foxt foxt mentioned this pull request Dec 21, 2021
@foxt foxt marked this pull request as draft December 21, 2021 03:35
@foxt
Copy link
Author

foxt commented Dec 21, 2021

Realised that always running String.fromCharCode will break compatibility with node, but fixes compatibility with the buffer polyfill I am using on the web. (https://github.com/feross/buffer)

Might be an idea to check if it is a string before running the switch statement, or just removing that change entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant