fix: resolve test hang caused by PostgreSQL lock conflict in test_cell.py#695
Open
aabhinavvvvvvv wants to merge 5 commits intojlab-sensing:mainfrom
Open
fix: resolve test hang caused by PostgreSQL lock conflict in test_cell.py#695aabhinavvvvvvv wants to merge 5 commits intojlab-sensing:mainfrom
aabhinavvvvvvv wants to merge 5 commits intojlab-sensing:mainfrom
Conversation
jmadden173
reviewed
Mar 21, 2026
Contributor
jmadden173
left a comment
There was a problem hiding this comment.
lgtm. Checked that the tests ran fully locally. Please fix the upstream conflict and I will merge in.
Contributor
|
Actually looks like I was able to fix the conflict. Can you run |
8dbf3f8 to
453bcc3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
@jmadden173 This PR is ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
test_cell.pyhad two tests using different fixtures (setup_cellsandinit_database) in the same module. Aftertest_cell_search_by_nameran a SELECT viaCell.search_by_name(), SQLAlchemy left an open implicit transaction holding a PostgreSQLAccessShareLockon thecelltable. Wheninit_databasethen calleddb.drop_all(), it neededAccessExclusiveLock— which PostgreSQL waited for indefinitely → hang.