Open
Conversation
Updating next method
The following line:
```fortran
do while (.not. associated(this%node_ptr) .or. .not. allocated(this%node_ptr%kv))
```
will cause problem.
When `this%node_ptr` not associated, and we access `this%node_ptr%kv`. it will cause segmentation fault.
Usually compiler does not have short circuit check like phthon and other language.
So I have modified this line.
```fortran
DO
IF(ASSOCIATED(this%node_ptr)) THEN
IF(ALLOCATED(this%node_ptr%kv) ) EXIT
END IF
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating next method
The following line:
will cause problem.
When
this%node_ptrnot associated, and we accessthis%node_ptr%kv. it will cause segmentation fault.Usually compiler does not have short circuit check like phthon and other language.
So I have modified this line.