Skip to content

Use golangci-lint rather than gometalinter #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use golangci-lint rather than gometalinter #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9611ce
Use golangci-lint rather than gometalinter
squaremo Mar 31, 2020
4d6d0f3
Build golangci-lint into the build image
squaremo Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ language: minimal
env:
global:
- GOVERSION=1.13.8
- GOMETALINTER_VERSION=2.0.11
- GOLANGCI_LINT_VERSION=v1.24.0
- GITHUB_RELEASE_VERSION=0.7.2

matrix:
Expand All @@ -31,9 +31,8 @@ matrix:
# go
- (cd ~ && curl -fsSLO https://dl.google.com/go/go${GOVERSION}.darwin-amd64.tar.gz)
- mkdir ~/go-${GOVERSION} && tar xf ~/go${GOVERSION}.darwin-amd64.tar.gz -C ~/go-${GOVERSION} --strip-components 1
# gometalinter
- (cd ~ && curl -fsSLO https://github.com/alecthomas/gometalinter/releases/download/v${GOMETALINTER_VERSION}/gometalinter-${GOMETALINTER_VERSION}-darwin-amd64.tar.gz)
- tar -xf ~/gometalinter-${GOMETALINTER_VERSION}-darwin-amd64.tar.gz -C /usr/local/bin --strip-components 1
# golangci-linter
- (cd ~ && curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s ${GOLANGCI_LINT_VERSION})
# github-release
- (cd ~ && curl -fsSLO https://github.com/aktau/github-release/releases/download/v${GITHUB_RELEASE_VERSION}/darwin-amd64-github-release.tar.bz2)
- tar -xf ~/darwin-amd64-github-release.tar.bz2 -C /usr/local/bin --strip-components 3
Expand Down
7 changes: 3 additions & 4 deletions build/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,10 @@ ENV ARCH x64
RUN curl -fsSLO --compressed "https://nodejs.org/dist/v$NODE_VERSION/node-v$NODE_VERSION-linux-$ARCH.tar.xz" \
&& tar -xJf "node-v$NODE_VERSION-linux-$ARCH.tar.xz" -C /usr/local --strip-components=1 --no-same-owner

# Fetch gometalinter
ENV GOMETALINTER_VERSION 2.0.11
# Fetch golangci-lint
ENV GOLANGCI_LINT_VERSION v1.24.0
ENV ARCH amd64
RUN curl -fsSLO --compressed "https://github.com/alecthomas/gometalinter/releases/download/v$GOMETALINTER_VERSION/gometalinter-$GOMETALINTER_VERSION-linux-$ARCH.tar.gz" \
&& tar -xf "gometalinter-$GOMETALINTER_VERSION-linux-$ARCH.tar.gz" -C /usr/local/bin --strip-components=1 --no-same-owner
RUN curl -fsSLO curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_LINT}

# Fetch gosu
ENV GOSU_VERSION 1.11
Expand Down
17 changes: 9 additions & 8 deletions run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,15 @@ echo "==> Running eslint on examples"

echo
echo "==> Running go linters"
gometalinter --tests --vendor --disable-all --deadline=600s \
--enable=misspell \
--enable=vet \
--enable=ineffassign \
--enable=gofmt \
--enable=deadcode \
--enable=golint \
./...
golangci-lint run --no-config --timeout=600s \
--disable-all --enable=deadcode --enable=golint --enable=varcheck \
--enable=structcheck --enable=dupl --enable=ineffassign \
--enable=interfacer --enable=govet --enable=gofmt --enable=misspell \
./...

# these are unused linters at present; some may fail.
# --enable=unconvert --enable=megacheck --enable=errcheck --enable=maligned
# --enable=goconst --enable=gosec

# Tests, both unit tests and integration tests under /tests
echo
Expand Down