Enable calculating solints on a per-EB basis#113
Open
psheehan wants to merge 31 commits into
Open
Conversation
…pip_installable+per_EB_solints
…ly happening so that tests pass (if changes haven't messed that up).
…pip_installable+per_EB_solints
…e_pip_installable+per_EB_solints
… to the function.
…allable+per_EB_solints+testing
…e_pip_installable+per_EB_solints+testing
…e_pip_installable+per_EB_solints
…allable+per_EB_solints+testing
…e+per_EB_solints+testing
…d the interval instead of the actual stage name in the solint settings. Also enable proper comparison of None types.
Collaborator
Author
|
A few additional notes:
|
…e+per_EB_solints+testing
…ed up properly. Also add some informative messaging, and add telescope to the list of excluded keys because it is new.
…al solint name in the solint settings to keep track of special solints like scan_inf and 300s_ap
…aluating which fields should be gaincal'd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up to this point we have assumed that input datasets have similar properties, but as we move towards group self-calibration or heterogenous dataset selfcal we need to be able to relax that assumption. This PR is to enable auto_selfcal to calculate the solution intervals separately for each dataset so that datasets with very different on source times, observing patterns, etc. can have their own, optimized solution intervals but all be self-calibrated together.
@jjtobin - we'll want to look at this one carefully. In particular, I'm not certain I incorporated the delay calibration option correctly so that may need some updates. But opening the PR to start the testing as the bulk of the changes should be in order.