Conversation
Easily repro the state of the test in the app by copy-pasting that slug.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the “configuration via file” experience and related editor/diagnostics behavior, including better configurability of compilation, improved diagnostics severity handling, and an option to preview rendered HTML output.
Changes:
- Add support for configuration code to customize the final
CSharpCompilationand improve configuration-language-services behavior by preloading compiler assemblies. - Refactor diagnostic-to-marker conversions to support severity mapping (e.g., include hidden diagnostics behavior).
- Add an HTML output toolbar option to preview rendered HTML (via
iframe srcdoc) and bump Roslyn/Razor package versions.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/UnitTests/Utils/TestUtil.cs | Adds test-time logging hook for compilation inputs. |
| test/UnitTests/LanguageServiceTests.cs | Adds coverage for hidden diagnostics inclusion behavior. |
| test/UnitTests/CompilerProxyTests.cs | Adds test for configuration-driven compilation mutation (missing member scenario). |
| src/WorkerApi/Lab/CompilerProxyOptions.cs | Adds a delegate hook to log compilation inputs. |
| src/Worker/Lab/CompilerProxy.cs | Implements compiler-assembly loader, adds compilation input logging, and makes built-in cache concurrent. |
| src/Shared/MonacoEditor.cs | Replaces downgradeInfo boolean with a severity-mapping function. |
| src/Shared/ILanguageServices.cs | Introduces ICompilerAssemblyLoader for preloading built-in assemblies. |
| src/Shared/ICompiler.cs | Threads severity mapping into marker conversion API surface. |
| src/Shared/Executor.cs | Allows user assemblies to configure DI before HTML rendering. |
| src/RoslynAccess/RoslynAccessors.cs | Adds WithIgnoreAccessibility() helper for configuration compilation options. |
| src/Compiler/Utils/Utils.cs | Adds severity mapping to Diagnostic -> DiagnosticData conversion. |
| src/Compiler/LanguageServices.cs | Preloads compiler assemblies for configuration and refactors compiler-assembly reference updates; adjusts marker severity mapping usage. |
| src/Compiler/Compiler.cs | Makes configuration execution async, upgrades hidden diagnostic severity when requested, enables internal/ignore-accessibility for configuration, and applies Config compilation transforms. |
| src/Compiler/Api.cs | Adds Config.CSharpCompilation(...) customization pipeline. |
| src/App/Lab/Page.razor | Adds “Rendered” HTML preview toggle and iframe-based rendering. |
| README.md | Adds more external links (REPLs/playgrounds). |
| Directory.Packages.props | Updates Roslyn/Razor package version properties. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.