Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves async execution in the Executor by clearing the SynchronizationContext to prevent deadlocks, unwrapping TargetInvocationException to preserve original stack traces, adding IL pattern matching for AsyncHelpers.HandleAsyncEntryPoint, and moving async-related tests to ExecutorTests.cs.
Changes:
- Clear
SynchronizationContextbefore invoking user code and remove now-unnecessaryConfigureAwait(false)calls - Unwrap
TargetInvocationExceptionviaExceptionDispatchInfo.Throwto preserve original stack traces, with new exception tests - Add IL patterns for
AsyncHelpers.HandleAsyncEntryPointentry points and fix tab click behavior in the Razor UI
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Shared/Executor.cs | Core async execution improvements: SynchronizationContext clearing, exception unwrapping, new IL patterns |
| test/UnitTests/ExecutorTests.cs | Added async main and exception tests, moved from CompilerProxyTests |
| test/UnitTests/CompilerProxyTests.cs | Removed async main tests (moved to ExecutorTests) |
| src/App/Lab/Page.razor | Fix tab click to avoid interfering with rename mode; focus editor on tab click |
| global.json | SDK version bump to preview.2 |
| Directory.Packages.props | .NET version bump to preview.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.