Skip to content

feat: /Users endpoint 작성 - #79

Open
parkj12b wants to merge 24 commits into
mainfrom
parkj12b/issue72
Open

parkj12b wants to merge 24 commits into
mainfrom
parkj12b/issue72

Conversation

@parkj12b

Copy link
Copy Markdown
Contributor

Closes #72

@parkj12b parkj12b added the enhancement New feature or request label Dec 15, 2024
@parkj12b parkj12b self-assigned this Dec 15, 2024
@parkj12b
parkj12b requested a review from jimin52 December 15, 2024 05:05
@codecov

codecov Bot commented Dec 15, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 31.83857% with 152 lines in your changes missing coverage. Please review.

Project coverage is 57.30%. Comparing base (12be539) to head (871f052).

Files with missing lines Patch % Lines
backend/src/users/users.service.ts 16.04% 57 Missing and 11 partials ⚠️
backend/src/users/users.controller.ts 24.65% 47 Missing and 8 partials ⚠️
backend/src/common/utils/paginate.utils.ts 18.18% 9 Missing ⚠️
backend/src/common/utils/utils.ts 27.27% 7 Missing and 1 partial ⚠️
backend/src/users/mockdata/users.mockdata.ts 0.00% 6 Missing ⚠️
backend/src/app.module.ts 0.00% 2 Missing ⚠️
backend/src/users/users.module.ts 0.00% 2 Missing ⚠️
backend/src/config.ts 0.00% 1 Missing ⚠️
backend/src/users/schema/users.schema.ts 95.65% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #79       +/-   ##
===========================================
+ Coverage   11.59%   57.30%   +45.71%     
===========================================
  Files          48       54        +6     
  Lines         664      855      +191     
  Branches        0       33       +33     
===========================================
+ Hits           77      490      +413     
+ Misses        587      345      -242     
- Partials        0       20       +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread backend/src/users/users.service.ts Outdated
Comment thread backend/src/users/users.service.ts Outdated
Comment thread backend/src/users/mockdata/users.mockdata.ts Outdated
Comment thread backend/src/common/utils/utils.ts
Comment thread backend/src/users/users.service.ts Outdated
@scarf005 scarf005 changed the title /Users endpoint 작성 feat: /Users endpoint 작성 Dec 15, 2024
Comment thread .env.example
Comment thread backend/src/common/utils/paginate.utils.ts
Comment thread backend/src/common/dto/dto.ts
Comment thread backend/src/common/schema/schema.ts
Comment thread backend/src/users/users.service.ts Outdated

@parkj12b parkj12b left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

case insensitive 해야하는 이유가 있나요?

url 은 lower case 를 많이써서 case insesntivie 해야 하는줄 알았는데 그게 아니었네요

@parkj12b
parkj12b requested a review from jimin52 December 29, 2024 15:38
@scarf005
scarf005 self-requested a review January 5, 2025 07:38

@jimin52 jimin52 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 approve 하겠습니다

Comment thread backend/src/users/users.controller.ts Outdated
scarf005 and others added 7 commits January 5, 2025 17:34
* feat: typeorm migrate 위한 파일 정리 및 config 수정

* refactor: 파일 경로 변경에 의한 import 변경

* migrate: typeorm migrate 성공

* [autofix.ci] apply automated fixes

* chore: readme migration 방법 추가

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/Users

3 participants