prevent addition of @JsonIgnoreProperties for entity with DTO mapping and database-type as sql #30268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oreProperties entities generated with dto mapping should not include @JsonIgnoreProperties for sql databases, as it can lead to unexpected serialization behavior. this change ensures that @JsonIgnoreProperties is only added to entities when not using dto mapping & for nosql (like mongodb, cassandra) Fix jhipster#29835
|
Hi maintainers, Workflow Job Log (ref: 47359660799) CI is failing for this PR due to errors (dependency convergence, disk space, Chrome crashes, etc.) that are also seen in other recent PRs ([#30254], [#30234], [#30223]). These issues seem to be related to the CI environment and not my changes. Could you please review the code logic in this PR and, if possible, check the underlying CI issue, or let me know what would be the best thing for me to follow Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #29835
ISSUE :
Entities generated with DTO mappings have included @JsonIgnoreProperties for SQL databases,
and it can lead to unexpected serialization behavior.
SOLUTION :
This change ensures that @JsonIgnoreProperties is only added to entities when:
Not using DTO mapping
Using NoSQL databases (like MongoDB or Cassandra)
Entities using DTOs rely on MapStruct for transformation, so @JsonIgnoreProperties is unnecessary
For SQL databases, this prevents unnecessary annotations and results in cleaner entity generation