Skip to content

Conversation

@barv-jfrog
Copy link
Contributor

@barv-jfrog barv-jfrog commented Sep 30, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Description:
As part of support of cocoapods in jf audit, we want to enable configuration of an artifactory cocoapods repository that serves as the base of dependency installation in jf audit.

omerzi and others added 30 commits April 5, 2023 10:15
* Improve UI for scan command (jfrog#706)

* Upgrade go version in go.mod to 1.20 (jfrog#732)

* Fix lint issues found (jfrog#733)

* Config transfer - ensure target not older than source (jfrog#721)

* Update tests environment - nuget and dotnet to version 6  (jfrog#734)

* Flatten audit graph (jfrog#736)

* Use gradle-dep-tree with Audit (jfrog#719)

---------

Co-authored-by: Sara Omari <[email protected]>
Co-authored-by: Eyal Ben Moshe <[email protected]>
Co-authored-by: Michael Sverdlov <[email protected]>
Co-authored-by: Yahav Itzhak <[email protected]>
# Conflicts:
#	.github/workflows/analysis.yml
#	go.mod
#	go.sum
#	xray/audit/java/gradle.go
#	xray/commands/audit/generic/auditmanager.go
@barv-jfrog barv-jfrog changed the title cocoapods-audit Cocoapods config for artifactory repositories Sep 30, 2024
@eyalbe4 eyalbe4 changed the title Cocoapods config for artifactory repositories Cocoapods config for Artifactory repositories Sep 30, 2024
@eyalbe4 eyalbe4 added the improvement Automatically generated release notes label Sep 30, 2024
@@ -0,0 +1,177 @@
package cocoapods

Copy link
Contributor

@eyalbe4 eyalbe4 Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command (and file) should be moved to be inside the jfrog-cli-security go module.

Copy link
Contributor

@srmish-jfrog srmish-jfrog Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? This isn't the "audit" command, it's just for setting RT as the dep resolution server... I didn't see any SetArtifactoryAsResolutionServer functions being defined in jfrog-cli-security, only here (jfrog-cli-core)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will move it to reduce cross-team dependencies

@eyalbe4
Copy link
Contributor

eyalbe4 commented Nov 1, 2024

Closing this one, since it's been replaced by #1288.

@eyalbe4 eyalbe4 closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.