Skip to content

Conversation

@yahavi
Copy link
Member

@yahavi yahavi commented Sep 4, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Every time a user interactively logs in to the JFrog platform, they are asked the following question:

Is the Artifactory reverse proxy configured to accept a client certificate?

This pull request removes that question.

  • For the jf c add command, users still can provide certificates using the --client-cert-key-path and --client-cert-path flags if necessary.
  • For the jf login command, self-signed certificates will not be supported at this time. Users should use the jf c add command instead.

@yahavi yahavi added the improvement Automatically generated release notes label Sep 4, 2024
@yahavi yahavi requested review from RobiNino and eyalbe4 September 4, 2024 07:44
@yahavi yahavi self-assigned this Sep 4, 2024
@yahavi yahavi changed the title Remove cert question in config add Remove self-signed certificate question in config add Sep 4, 2024
@yahavi yahavi changed the title Remove self-signed certificate question in config add Remove self-signed certificate question in Config Sep 4, 2024
@yahavi yahavi merged commit 7a9f46d into jfrog:dev Sep 9, 2024
1 check failed
@yahavi yahavi deleted the rm-cert-question branch September 9, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants