New transitive decorator #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
orto17
commented
Nov 5, 2025
orto17
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
- Update documentation about new features / new supported technologies
github-actions
bot
removed
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
force-pushed
the
new-transitive-decorator
branch
from
9466cdb to
cba8e0b
Compare
orto17
force-pushed
the
new-transitive-decorator
branch
from
bb75cf7 to
4e3a1f0
Compare
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
orto17
added
the
safe to test
github-actions
bot
removed
the
safe to test
Contributor
kerenr-jfrog
approved these changes
Nov 13, 2025
attiasas
requested changes
Nov 13, 2025
Contributor
attiasas
left a comment
attiasas
left a comment
There was a problem hiding this comment.
Nice work!
- fix tests
- make sure to validate output before merging
utils/outputwriter/outputcontent.go
Outdated
Comment on lines
654
to
667
| if len(path) < 2 { | ||
| continue | ||
| } | ||
| // First element is always a direct dependency | ||
| first := path[0] | ||
| key := fmt.Sprintf("%s:%s", first.Name, first.Version) | ||
| directDeps[key] = first | ||
|
|
||
| for i := 1; i < len(path)-1; i++ { | ||
| component := path[i] | ||
| key := fmt.Sprintf("%s:%s", component.Name, component.Version) | ||
| transitiveDeps[key] = component | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
The first node in the impact path is the scanned component itself. The second one is the direct dependency, check getDirectComponentsAndImpactPaths in security CLI
Contributor
There was a problem hiding this comment.
also it means that transitive is: if more than 2 in impact path => the impacted component is transitive
attiasas
requested changes
Nov 13, 2025
attiasas
approved these changes
Nov 13, 2025
Contributor
attiasas
left a comment
attiasas
left a comment
There was a problem hiding this comment.
make sure to validate content by running tests on both types of providers for the content you produce
orto17
force-pushed
the
new-transitive-decorator
branch
from
14d5703 to
4c32e05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.