Skip to content

Bugfix/fixme xyitemrenderer getannotations #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v1.5.x
Choose a base branch
from
Open

Bugfix/fixme xyitemrenderer getannotations #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e54213
Exposing getAnnotations method on XYItemRenderer interface
Apr 26, 2021
2ea2bd4
Merge remote-tracking branch 'jfree/v1.5.x' into bugfix/fixme_xyitemr…
Yuri-Blankenstein-TNO Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/main/java/org/jfree/chart/plot/XYPlot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4158,11 +4158,8 @@ public Range getDataRange(ValueAxis axis) {
DatasetUtils.findRangeBounds(d));
}
}
// FIXME: the XYItemRenderer interface doesn't specify the
// getAnnotations() method but it should
if (r instanceof AbstractXYItemRenderer) {
AbstractXYItemRenderer rr = (AbstractXYItemRenderer) r;
Collection c = rr.getAnnotations();
if (r != null) {
Collection c = r.getAnnotations();
Iterator i = c.iterator();
while (i.hasNext()) {
XYAnnotation a = (XYAnnotation) i.next();
Expand Down
8 changes: 8 additions & 0 deletions src/main/java/org/jfree/chart/renderer/xy/XYItemRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
import java.awt.Shape;
import java.awt.Stroke;
import java.awt.geom.Rectangle2D;
import java.util.Collection;

import org.jfree.chart.LegendItem;
import org.jfree.chart.LegendItemSource;
Expand Down Expand Up @@ -1335,6 +1336,13 @@ void setSeriesCreateEntities(int series, Boolean create,
*/
void addAnnotation(XYAnnotation annotation, Layer layer);

/**
* Returns all annotations of all layers currently added to this renderer.
*
* @return all annotations for this renderer
*/
public Collection getAnnotations();

/**
* Removes the specified annotation and sends a {@link RendererChangeEvent}
* to all registered listeners.
Expand Down