Tidy codes

Signed-off-by: Jack Cherng <[email protected]>

Author: jfcherng

src/Renderer/Html/Combined.php

@@ -182,6 +182,10 @@ protected function renderTableBlockDelete(array $block): string
      */
     protected function renderTableBlockReplace(array $block): string
     {
+        if ($this->options['detailLevel'] === 'none') {
+            return $this->renderTableBlockDelete($block) . $this->renderTableBlockInsert($block);
+        }
+
         $html = '';
 
         $oldLines = $block['old']['lines'];
@@ -197,12 +201,6 @@ protected function renderTableBlockReplace(array $block): string
             $oldLinesCount = $newLinesCount = 1;
         }
 
-        // fix for "detailLevel" is "none"
-        if ($this->options['detailLevel'] === 'none') {
-            $this->fixLinesForNoClosure($oldLines, RendererConstant::HTML_CLOSURES_DEL);
-            $this->fixLinesForNoClosure($newLines, RendererConstant::HTML_CLOSURES_INS);
-        }
-
         // now $oldLines must has the same line counts with $newlines
         for ($no = 0; $no < $newLinesCount; ++$no) {
             $mergedLine = $this->mergeReplaceLines($oldLines[$no], $newLines[$no]);
@@ -215,9 +213,7 @@ protected function renderTableBlockReplace(array $block): string
 
             $html .=
                 '<tr data-type="!">' .
-                    '<td class="rep">' .
-                        $mergedLine .
-                    '</td>' .
+                    '<td class="rep">' . $mergedLine . '</td>' .
                 '</tr>';
         }
 
@@ -396,23 +392,6 @@ protected function markReplaceBlockDiff(array $oldBlock, array $newBlock): array
         ];
     }
 
-    /**
-     * Wrap the whole line with closures if it does not have one.
-     *
-     * @param string[] $lines    the lines
-     * @param string[] $closures the closures
-     */
-    protected function fixLinesForNoClosure(array &$lines, array $closures): void
-    {
-        foreach ($lines as &$line) {
-            // there is no closure in a "replace"-type line
-            // this means that the entire line changes
-            if (false === \strpos($line, $closures[0])) {
-                $line = "{$closures[0]}{$line}{$closures[1]}";
-            }
-        }
-    }
-
     /**
      * Determine whether the "replace"-type lines are merge-able or not.
      *