Combined: do not merge blocks which change too much

#20 (comment)

Signed-off-by: Jack Cherng <[email protected]>

Author: jfcherng

src/Renderer/Html/Combined.php

@@ -205,10 +205,18 @@ protected function renderTableBlockReplace(array $block): string
 
         // now $oldLines must has the same line counts with $newlines
         for ($no = 0; $no < $newLinesCount; ++$no) {
+            $mergedLine = $this->mergeReplaceLines($oldLines[$no], $newLines[$no]);
+
+            if (!isset($mergedLine)) {
+                $html .= $this->renderTableBlockDelete($block) . $this->renderTableBlockInsert($block);
+
+                continue;
+            }
+
             $html .=
                 '<tr data-type="!">' .
                     '<td class="rep">' .
-                        $this->mergeReplaceLines($oldLines[$no], $newLines[$no]) .
+                        $mergedLine .
                     '</td>' .
                 '</tr>';
         }
@@ -225,8 +233,10 @@ protected function renderTableBlockReplace(array $block): string
      *
      * @param string $oldLine the old line
      * @param string $newLine the new line
+     *
+     * @return null|string string if merge-able, null otherwise
      */
-    protected function mergeReplaceLines(string $oldLine, string $newLine): string
+    protected function mergeReplaceLines(string $oldLine, string $newLine): ?string
     {
         $delParts = $this->analyzeClosureParts(
             RendererConstant::HTML_CLOSURES_DEL[0],
@@ -254,6 +264,11 @@ protected function mergeReplaceLines(string $oldLine, string $newLine): string
             );
         }
 
+        // note that $mergedLine is actually a clean line at this point
+        if (!$this->isLinesMergeable($oldLine, $newLine, $mergedLine)) {
+            return null;
+        }
+
         // before building the $mergedParts, we do some adjustments
         $this->revisePartsForBoundaryNewlines($delParts, RendererConstant::HTML_CLOSURES_DEL);
         $this->revisePartsForBoundaryNewlines($insParts, RendererConstant::HTML_CLOSURES_INS);
@@ -398,6 +413,26 @@ protected function fixLinesForNoClosure(array &$lines, array $closures): void
         }
     }
 
+    /**
+     * Determine whether the "replace"-type lines are merge-able or not.
+     *
+     * @param string $oldLine   the old line
+     * @param string $newLine   the new line
+     * @param string $cleanLine the clean line
+     */
+    protected function isLinesMergeable(string $oldLine, string $newLine, string $cleanLine): bool
+    {
+        $oldLine = \str_replace(RendererConstant::HTML_CLOSURES_DEL, '', $oldLine);
+        $newLine = \str_replace(RendererConstant::HTML_CLOSURES_INS, '', $newLine);
+
+        $sumLength = \strlen($oldLine) + \strlen($newLine);
+
+        /** @var float the changed ratio, 0 <= range < 1 */
+        $changedRatio = ($sumLength - (\strlen($cleanLine) << 1)) / ($sumLength + 1);
+
+        return $changedRatio < 0.8;
+    }
+
     /**
      * Extract boundary newlines from parts into new parts.
      *