Improve buffer pools stats and dump #14123
Merged
+122
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot enabled Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
sbordet
requested changes
Dec 3, 2025
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/CompoundPool.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/internal/QueuedPool.java
Show resolved
Hide resolved
jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/ArrayByteBufferPool.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ludovic Orban <[email protected]>
Signed-off-by: Ludovic Orban <[email protected]>
sbordet
approved these changes
Dec 3, 2025
lorban
added a commit
that referenced
this pull request
Dec 3, 2025
- record non-pooled acquisitions as a single bucket when stats are disabled - make buckets include the wrapped `oeju.Pool` instance when dumped - make `ArrayRetainableByteBuffer.Tracking` dump leaks when dumped - save the stack of non-pooled acquisitions to include them in the dump Signed-off-by: Ludovic Orban <[email protected]>
lorban
added a commit
that referenced
this pull request
Dec 3, 2025
- record non-pooled acquisitions as a single bucket when stats are disabled - make buckets include the wrapped `oeju.Pool` instance when dumped - make `ArrayRetainableByteBuffer.Tracking` dump leaks when dumped - save the stack of non-pooled acquisitions to include them in the dump Signed-off-by: Ludovic Orban <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oeju.Poolinstance when dumpedArrayRetainableByteBuffer.Trackingdump leaks when dumped