Updated documentation about InvocationType, for both client and server. #13376
+630
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simone Bordet <[email protected]>
joakime
reviewed
Jul 29, 2025
documentation/jetty/modules/programming-guide/pages/arch/threads.adoc
Outdated
Show resolved
Hide resolved
joakime
previously requested changes
Jul 29, 2025
There was a problem hiding this comment.
I can follow the documentation here quite well.
With the one exception being the term "the take-over production task".
That one is unclear and had be re-reading that same section multiple times in a attempt to understand what that is referring to.
Can we make that more clear please?
|
@joakime not sure how. The take-over production task is defined in the previous paragraph, perhaps you missed it? |
lorban
previously approved these changes
Aug 4, 2025
gregw
approved these changes
Aug 4, 2025
documentation/jetty/modules/programming-guide/pages/arch/threads.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/programming-guide/pages/arch/threads.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/programming-guide/pages/arch/threads.adoc
Outdated
Show resolved
Hide resolved
documentation/jetty/modules/programming-guide/pages/arch/threads.adoc
Outdated
Show resolved
Hide resolved
gregw
requested changes
Aug 4, 2025
Signed-off-by: Simone Bordet <[email protected]>
…1.x/InvocationType-docs
use consume instead of run
Signed-off-by: Simone Bordet <[email protected]>
Signed-off-by: Simone Bordet <[email protected]>
lorban
approved these changes
Aug 29, 2025
gregw
approved these changes
Aug 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.