Improved link file finding #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e archive path isn't present on the local machine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When trying to access the file path of a linked block from a file that has been downloaded from an external source, the file path will be a location on the machine of the person who created that file. This can be fixed by opening the Rhino file and saving it. But it's an extra step that's unintuitive.
Solution: If the file path can't be found locally, comb through sub-directories to locate the linked block file. When found, adjust the 'source_archive' variable accordingly. This is a simplified implementation of how Rhino handles the finding of linked files. https://wiki.mcneel.com/rhino/rhinov5status_filefinding