-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Update Fedora section of the README.md file #4792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Happy to merge this if it's better than what we had before. But can I ask how determined you are to keep this up-to-date? When looking at the source repo of the RPM spec, it seems that a lot of lazygit releases were skipped. |
Absolutely valid question. I do update the SPEC file when I notice when there is a release. I did not have time to look if this process can be automated but that is definitely in my TODO list. lazygit is at stage where there is everything I need, so it is not that I eagerly look forward to new release hoping for some bugfix to be there, like is case with some other tools. :) Experienced RPM user will know how to use the code from my lazygit RPM spec repo (link to it is in this PR) to build lazygit RPM package from any lazygit release. What we had before was an unmaintained COPR with latest lazygit RPM package being v0.47.2-1, which is why #4362 was made, and which is why I forked that code and made it up-to-date. |
Honestly, that sounds a little bit like we might be stuck at 0.53 from now on, which doesn't sound a lot better than being stuck at 0.47.2.
Yeah, but isn't it even easier to build from source then? Or to install from one of the tarballs of our release page. I don't know, an earlier suggestion was to remove the link entirely and recommend to install from our binary release instead, like we do for Ubuntu. I'm actually slightly in favor of that approach if there's any risk that this new RPM repo goes stale again too. We have regular releases now every month (always on the first Saturday of the month). If you are unsure whether you will be able to keep up with that, I'm hesitant to merge this. Automating it sounds good though. We do this for the homebrew package, and if you can find a way to do that for your repo, that would be great. |
We are at 0.54.0 at the moment actually (see: https://copr.fedorainfracloud.org/coprs/dejan/lazygit/builds/) If you do not want to merge this, then I suggest you merge #4362 instead and close this PR, as there is no point to keep it open. I will keep my COPR up to date whenever I see there is a new lazygit release, and as I said above I will look into ways to automate this so it is possible that in the future we may not see gaps in the releases. Anyway - up to you! |
Ok, I'll merge this; if we see after a few releases that this tends to fall behind, we can still reconsider and remove the link then. It seems to me that subscribing to our releases page should be a fairly reliable mechanism to get notified of new releases; could I ask you to do that? Maybe that's all the "automation" we need. |
👍 I have already looked at ways to do the automated notification and automated RPM SPEC update and build. Until the automation is done I will do as you say and subscribe to be notified of lazygit releases. |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [jesseduffield/lazygit](https://github.com/jesseduffield/lazygit) | patch | `v0.54.0` -> `v0.54.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jesseduffield/lazygit (jesseduffield/lazygit)</summary> ### [`v0.54.1`](https://github.com/jesseduffield/lazygit/releases/tag/v0.54.1) [Compare Source](jesseduffield/lazygit@v0.54.0...v0.54.1) <!-- Release notes generated using configuration in .github/release.yml at v0.54.1 --> This hotfix release fixes a regression in 0.54.0 that made lazygit fail on startup when multiple users use it on a single machine. For the changes in 0.54.0, see https://github.com/jesseduffield/lazygit/releases/tag/v0.54.0. #### What's Changed ##### Fixes 🔧 - Fix temp dir permission problem on multi-user machines by [@​stefanhaller](https://github.com/stefanhaller) in jesseduffield/lazygit#4796 ##### Maintenance ⚙️ - Stop updating Jesse's homebrew tap by [@​stefanhaller](https://github.com/stefanhaller) in jesseduffield/lazygit#4797 ##### Docs 📖 - Update Fedora section of the README.md file by [@​dejlek](https://github.com/dejlek) in jesseduffield/lazygit#4792 #### New Contributors - [@​dejlek](https://github.com/dejlek) made their first contribution in jesseduffield/lazygit#4792 **Full Changelog**: jesseduffield/lazygit@v0.54.0...v0.54.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS41My4xIiwidXBkYXRlZEluVmVyIjoiNDEuNTMuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
After discussion from the following PR ( #4362 ) I have finally found time to make a PR to update the Fedora section of the README.md file. I actually use those instructions myself from few different Fedora and Amazon Linux 2023 machines.
Here is an example of installing lazygit from the Copr: