Conversation
…yBuffer Externally-backed ArrayBuffer/SharedArrayBuffer objects wrap a caller-supplied buffer. When no array-buffer free callback is registered, garbage collection returns such a buffer to the JerryScript heap free list through jmem_heap_free_block_internal(). Its free-list linking writes the block header into the buffer, which runs past the end of buffers smaller than a free block. Mark externally-supplied buffers with a dedicated flag and skip the internal heap free for them when no free callback is registered. Registered free callbacks are still invoked, and the buffer is still treated as allocated so lazy allocation does not replace the caller's buffer. Fixes jerryscript-project#5272 JerryScript-DCO-1.0-Signed-off-by: PGZXB <pgzxb@qq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Externally-backed
ArrayBuffer/SharedArrayBufferobjects wrap a caller-suppliedbuffer. When no array-buffer free callback is registered, garbage collection
returns such a buffer to the JerryScript heap free list through
jmem_heap_free_block_internal(). Its free-list linking writes the block header(
size/next_offset) into the buffer, which runs past the end of bufferssmaller than a free block:
Mark externally-supplied buffers with a dedicated flag and skip the internal
heap free for them when no free callback is registered. Registered free
callbacks are still invoked, and the buffer is still treated as allocated so
lazy allocation does not replace the caller's buffer.
Fixes #5272
JerryScript-DCO-1.0-Signed-off-by: PGZXB pgzxb@qq.com