Conversation
JerryScript-DCO-1.0-Signed-off-by: Sai Asish Y say.apm35@gmail.com
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ecma_proxy_object_delete_propertyruns the two ProxyDeleteProperty result invariants (non-configurable property, non-extensible target) in sequence. When adeletePropertytrap returns true for a non-configurable property on a non-extensible target, both checks fail andecma_raise_type_erroris called twice. The second call raises a TypeError while one is already pending, which trips the!jcontext_has_pending_exception ()assertion and aborts assertion-enabled builds; release builds overwrite the pending exception state. Per the spec the non-configurable check throws and returns, so the extensibility check should only run when the property is configurable. Added a regression case to tests/jerry/proxy_delete.js that aborts before the change and passes after.Fixes #5296