Skip to content

Bugfix/php8.3 #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bugfix/php8.3 #67

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b767fc
Fixed SparkCommand.php to align with parent class return types.
tswagger Mar 18, 2025
ce83618
Fixed SparkCommand.php to align with parent class return types.
tswagger Mar 18, 2025
19df42a
Merge remote-tracking branch 'origin/bugfix/php8.3' into bugfix/php8.3
tswagger Mar 18, 2025
74097b1
Added missing return value
tswagger Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Commands/SparkCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

class SparkCommand extends Command
{
protected function configure()
protected function configure(): int
{
$this
->setName('spark')
Expand All @@ -35,9 +35,11 @@ protected function configure()
InputArgument::OPTIONAL,
'Your prime number'
);

return 1; // method requires an integer return value
}

protected function execute(InputInterface $input, OutputInterface $output)
protected function execute(InputInterface $input, OutputInterface $output): int
{
$bitLength = $input->getOption('bits');

Expand Down