fix bug that causes bottom margin option (-b) to be ignored #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outer margin would be used in its place
AvanRocks
changed the title
Author
|
I added 2 more commits that fix another (related) bug. The bug was that pdfcrop was being passed the parameters for the bounding boxes in the wrong order. Instead of Left, Bottom, Right, Top (as mentioned by |
|
Thank you for your bug fix. I also found this bug here @AvanRocks ! |
|
Done in my New pull request #16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a typo that caused opts.outerMargin to be used in place of opts.bottomMargin when setting the bottom of the bounding box for pdfcrop