Skip to content

[JENKINS-46124] - support map with EnvStep #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

stuartrowe
Copy link

@stuartrowe stuartrowe commented Jun 15, 2025

Fixes JENKINS-46124

Revival of #105 by @jetersen.

I forked jetersen:fix/JENKINS-46124 and merged the latest from jenkinsci:master.

I also completed the outstanding request to update the help text for the withEnv step and its overrides argument to mention the new map syntax.

Testing done

See mapArguments() and mapArgumentsAsMap() tests added in the original PR.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • [ x Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@stuartrowe stuartrowe requested a review from a team as a code owner June 15, 2025 03:48
@stuartrowe
Copy link
Author

@jetersen @dwnusbaum I hope this has been the right approach, but I would really like to see the changes from #105 merged and released 🙏.

@stuartrowe
Copy link
Author

@jglick @dwnusbaum @basil is anyone able to review this change please?

@jglick
Copy link
Member

jglick commented Jul 9, 2025

Well, I can put it on my backlog, but my backlog is pretty long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants