Skip to content

fix #343 by adding step related classes to whitelist #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix #343 by adding step related classes to whitelist #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions src/main/groovy/org/boozallen/plugins/jte/util/SandboxWhitelist.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@ import hudson.Extension
import org.boozallen.plugins.jte.init.primitives.TemplatePrimitive
import org.boozallen.plugins.jte.init.primitives.TemplatePrimitiveCollector
import org.boozallen.plugins.jte.init.primitives.TemplatePrimitiveNamespace
import org.boozallen.plugins.jte.init.primitives.hooks.HookContext
import org.boozallen.plugins.jte.init.primitives.hooks.HooksWrapper
import org.boozallen.plugins.jte.init.primitives.injectors.LibraryNamespace
import org.boozallen.plugins.jte.init.primitives.injectors.StageInjector
import org.boozallen.plugins.jte.init.primitives.injectors.StepContext
import org.boozallen.plugins.jte.init.primitives.injectors.StepWrapperScript
import org.jenkinsci.plugins.scriptsecurity.sandbox.whitelists.AbstractWhitelist
import org.boozallen.plugins.jte.init.governance.config.dsl.PipelineConfigurationBuilder
Expand All @@ -40,13 +43,17 @@ import java.lang.reflect.Method
]

private final List<Class> permittedReceivers = [
TemplatePrimitive,
TemplatePrimitiveCollector.JTEVar,
TemplatePrimitiveNamespace,
LibraryNamespace,
HooksWrapper,
PipelineConfigurationBuilder,
DslEnvVar
TemplatePrimitive,
TemplatePrimitiveCollector.JTEVar,
TemplatePrimitiveNamespace,
LibraryNamespace,
HooksWrapper,
PipelineConfigurationBuilder,
DslEnvVar,
StepWrapperScript,
HookContext,
StepContext,
StageInjector.StageContext
]

@Override
Expand Down
22 changes: 22 additions & 0 deletions ...groovy/org/boozallen/plugins/jte/init/primitives/injectors/LibraryStepInjectorSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,4 +225,26 @@ class LibraryStepInjectorSpec extends Specification {
jenkins.assertBuildStatusSuccess(run)
}

def "folder libraries can access config variable"() {
given:
// add folder
TestLibraryProvider lib2 = new TestLibraryProvider()
lib2.addStep("lib", "step", """
void call(){
assert config.x == 1
}
""")
Folder folder = jenkins.createProject(Folder)
lib2.addToFolder(folder)
// create job
WorkflowJob job = TestUtil.createAdHocInFolder(folder,
config: 'libraries{ lib { x = 1 } }',
template: 'step()'
)
when:
def run = job.scheduleBuild2(0).get()
then:
jenkins.assertBuildStatusSuccess(run)
}

}
Loading