Skip to content

Remove usages of Commons Lang 2 - #103

Merged
BorisYaoA merged 1 commit into
jenkinsci:masterfrom
timja:commons-lang3
Aug 25, 2026
Merged

Remove usages of Commons Lang 2#103
BorisYaoA merged 1 commit into
jenkinsci:masterfrom
timja:commons-lang3

Conversation

@timja-bot

Copy link
Copy Markdown

No need to depend on a third-party library here when the Java Platform provides this
functionality natively.

Part of the effort to remove Commons Lang 2 from Jenkins core — jenkinsci/jenkins#16404,
jenkinsci/jenkins#26105. Commons Lang 2 is EOL and carries an unfixed advisory
(GHSA-j288-q9x7-2f5v).

What's changed

  • HudsonNotificationPropertyDescriptor and Phase: StringUtils.isEmpty / isBlank become
    plain String checks. In Phase.isURLValid the value is already dereferenced on the line above,
    so no null guard is needed there — SpotBugs confirms the check would be redundant.
  • No dependency was added — this plugin did not declare Commons Lang, it came in transitively from
    core.
  • Enabled the ban-commons-lang-2 enforcer rule to prevent regressions.

Testing done

mvn -B -ntp clean verify passes locally on Java 21 / macOS.

The ban-commons-lang-2 enforcer rule is enabled in this PR, so the build fails if an
org.apache.commons.lang.* import comes back.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

🤖 This pull request was generated with AI assistance (Claude Code) as part of a bulk migration
across Jenkins plugins. If anything here looks wrong, please comment on this PR or contact @timja.

@timja-bot
timja-bot requested a review from a team as a code owner August 3, 2026 08:16

@BorisYaoA BorisYaoA left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @timja

@BorisYaoA
BorisYaoA merged commit e67968e into jenkinsci:master Aug 25, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants