Query the documentation to check if plugin is enabled #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of querying the plugin (which may give a redirect), query the plugin's Documentation.
Member
|
Can we assume all plugins have documentation? |
Member
|
Is there an issue number for this? |
Member
Author
|
I've not created an issue for this, I fixed it locally and just sent the PR upstreams :-) Based on memory I think it's fairly reliable to go on the documentation, but if not then maybe GerritPluginChecker should be refactored or renamed |
Member
|
I guess you could also make sure to login first? If the redirect is because Jenkins is not logged in iiuc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of querying the plugin (which may give a redirect), query the plugin's Documentation (which does not require authentication).