Skip to content

Fixed IP whitelist authorisation - #1157

Open
cozej4 wants to merge 2 commits into
jembi:masterfrom
cozej4:fix-ip-whitelist-authorization
Open

Fixed IP whitelist authorisation#1157
cozej4 wants to merge 2 commits into
jembi:masterfrom
cozej4:fix-ip-whitelist-authorization

Conversation

@cozej4

@cozej4 cozej4 commented Nov 5, 2021

Copy link
Copy Markdown

From the Documentation.

Whitelisted IP Addresses - A list of IP addresses that will be given access without authentication required.

Fixed issues in authorizing requests from whitelisted IP which should not require additional Client Authorisation

@codecov

codecov Bot commented Nov 5, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1157 (a4356c3) into master (999047c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1157      +/-   ##
==========================================
- Coverage   85.02%   85.00%   -0.02%     
==========================================
  Files          77       77              
  Lines        5247     5247              
==========================================
- Hits         4461     4460       -1     
- Misses        786      787       +1     
Impacted Files Coverage Δ
src/middleware/authorisation.js 100.00% <100.00%> (ø)
src/middleware/messageStore.js 89.60% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 999047c...a4356c3. Read the comment docs.

@MattyJ007

Copy link
Copy Markdown
Contributor

Thanks for the contribution @cozej4 💯
We will review this as soon as we can.

@cozej4

cozej4 commented Nov 10, 2021

Copy link
Copy Markdown
Author

Thanks for the contribution @cozej4 💯 We will review this as soon as we can.

Thanks @MattyJ007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants