detect delta cycles in resolve_object#2299
Open
netliomax25-code wants to merge 1 commit into
Open
Conversation
Owner
|
What does C Git do here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pack.resolve_objectwalks a pack object's delta chain, but the only cycle guard rejects a single self-referencing REF_DELTA (base_offset == prev_offset), so a pack holding two or more REF_DELTA objects that name each other is not caught.get_rawdrives that walk, so reading such an object never returns: each iteration re-inflates a delta and appends todelta_stack, so memory grows without bound. A pack file is untrusted input (a cloned or downloaded repository, a submodule, a pack read from disk).git index-packand dulwich's own streamingDeltaChainIteratorboth reject delta cycles; only this random-access path did not.UnresolvedDeltaswhen one repeats. Every cycle crosses at least one REF_DELTA edge (OFS_DELTA offsets strictly decrease), so this is enough to break any cycle, and valid chains visit distinct offsets so their result is unchanged.Verified with a two-object REF_DELTA cycle: before the change
get_rawhangs; after it raisesUnresolvedDeltas. Added a regression test covering that pack.