porcelain: honor Git SSH command env vars#2274
Draft
aouxwoux wants to merge 2 commits into
Draft
Conversation
Owner
|
I realize this is still marked as draft, but please note that GIT_SSH_COMMAND is now in dulwich.cli; we shouldn't support it in two places. If you think it should be elsewhere, let's have that discussion first. |
Author
|
Thanks, agreed. I pushed a follow-up that removes the porcelain-level For #2209, the remaining question is policy: the repro is via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GIT_SSH_COMMAND/GIT_SSHhandling for remote transportsssh_command=precedence over environment defaultsFixes #2209
Verification
python -m unittest tests.cli.test_cli.SshCommandFromEnvTest tests.porcelain.TransportKwargsTests tests.test_client.SSHGitClientTestspython -m ruff check dulwich/porcelain/__init__.py tests/porcelain/__init__.pygit diff --checkAlso attempted
python -m unittest tests.porcelainon Windows; it reached unrelated symlink tests that require symlink privileges and failed withWinError 1314.