-
-
Notifications
You must be signed in to change notification settings - Fork 38
Fix URL parsing issues #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…lify URL manipulation
8e2085f to
363cd42
Compare
1hitsong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality seems to work to me 🤘🏻. Code style changes requested.
Co-authored-by: 1hitsong <[email protected]>
Co-authored-by: 1hitsong <[email protected]>
Co-authored-by: 1hitsong <[email protected]>
Co-authored-by: 1hitsong <[email protected]>
Co-authored-by: 1hitsong <[email protected]>
1hitsong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more style pass. Everything else is looking good to me.
Do you want your name in the What's New content popup? If so, add an entry to the source\static\whatsNew\3.0.13.json file.
I'd suggest the description be something like "Add support for querystring values in server address"
Co-authored-by: 1hitsong <[email protected]>
Co-authored-by: 1hitsong <[email protected]>
Co-authored-by: 1hitsong <[email protected]>
Co-authored-by: 1hitsong <[email protected]>
Co-authored-by: 1hitsong <[email protected]>
|
thanks for persevering @1hitsong - I've applied your suggestions and updated "what's new" now |
1hitsong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job.
I recently had an issue connecting my Roku device to my Jellyfin server as my server is setup to expect certain query string values in the URL. When I looked into the code, I found that this was due to the URL parsing logic during server selection not accounting for the presence of a query string and appending the API path to the end of the URL, making it invalid.
Changes
misc.inferServerUrl,misc.urlCandidatesandbaserequest.buildURLto properly handle query string values present in the given URLbaserequest.buildURLwhen certain functions include the query params inpathrather thanparamsmisc.parseUrlwith newParsedUrlfunction (defined inparsedUrl.bs), which returns an associative array of URI components parsed from the given URL and defines helper functions for manipulating it safelyIssues
#601