Skip to content

Conversation

@GeekJosh
Copy link
Contributor

@GeekJosh GeekJosh commented Nov 15, 2025

I recently had an issue connecting my Roku device to my Jellyfin server as my server is setup to expect certain query string values in the URL. When I looked into the code, I found that this was due to the URL parsing logic during server selection not accounting for the presence of a query string and appending the API path to the end of the URL, making it invalid.

Changes

  • update the logic in misc.inferServerUrl, misc.urlCandidates and baserequest.buildURL to properly handle query string values present in the given URL
  • fix an issue in baserequest.buildURL when certain functions include the query params in path rather than params
  • replace misc.parseUrl with new ParsedUrl function (defined in parsedUrl.bs), which returns an associative array of URI components parsed from the given URL and defines helper functions for manipulating it safely

Issues

#601

@GeekJosh GeekJosh requested a review from a team as a code owner November 15, 2025 19:57
Copy link
Member

@1hitsong 1hitsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality seems to work to me 🤘🏻. Code style changes requested.

@GeekJosh GeekJosh requested a review from 1hitsong November 27, 2025 21:21
Copy link
Member

@1hitsong 1hitsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more style pass. Everything else is looking good to me.

Do you want your name in the What's New content popup? If so, add an entry to the source\static\whatsNew\3.0.13.json file.

I'd suggest the description be something like "Add support for querystring values in server address"

@GeekJosh
Copy link
Contributor Author

GeekJosh commented Dec 2, 2025

thanks for persevering @1hitsong - I've applied your suggestions and updated "what's new" now

@GeekJosh GeekJosh requested a review from 1hitsong December 2, 2025 18:08
Copy link
Member

@1hitsong 1hitsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

@1hitsong 1hitsong merged commit 87c88f2 into jellyfin:master Dec 2, 2025
1 check passed
@cewert cewert mentioned this pull request Dec 5, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants