Implement a yaml for what parameters are allowed so we can disable temperature, max tokens, etc for GPT5+ #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use max_completion_tokens via extra_body; hide unsupported options in UI; improve length handling and reduce overhead
boxman0617
approved these changes
Sep 16, 2025
boxman0617
left a comment
boxman0617
left a comment
There was a problem hiding this comment.
This is exactly what I was looking for! LGTM! Thanks random stranger!!!
jekalmin
reviewed
Dec 13, 2025
Owner
jekalmin
left a comment
jekalmin
left a comment
There was a problem hiding this comment.
Thanks for your work!
It would be a great idea if supported parameters of models are managed in yaml and in sync with options.
Comment on lines
+416
to
+418
| tokens_value = min(max(tokens_value * 2, observed + 256), max_cap) | ||
| if attempt < 3: | ||
| continue |
Owner
There was a problem hiding this comment.
Could you explain this in detail?
I want to know about the reasons behind retrying even if max_token is reached.
| if _SUPPORTED_PARAMS_SPEC is not None: | ||
| return _SUPPORTED_PARAMS_SPEC | ||
|
|
||
| spec_path = os.path.join(os.path.dirname(__file__), "supported_parameters.yaml") |
Owner
There was a problem hiding this comment.
Could you resolve this warning?
WARNING (MainThread) [homeassistant.util.loop] Detected blocking call to open with args ('/workspaces/home-assistant-core/config/custom_components/extended_openai_conversation/supported_parameters.yaml', 'r')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.