Skip to content

Conversation

@thomasgeens
Copy link
Contributor

@thomasgeens thomasgeens commented Feb 24, 2025

This pull request adds documentation and an example for a new function to set a preset mode on a fan entity. The change includes details about the function's objective, parameters, and implementation.

Documentation and example addition:

  • examples/function/fan/README.md: Added a new section describing the set_fan_preset_mode function, including its objective, YAML specification, and usage for setting a fan's preset mode to off, low, or high.

[no-issue]

@thomasgeens
Copy link
Contributor Author

An additional image might need to be added as per your other examples.

@thomasgeens thomasgeens marked this pull request as ready for review February 24, 2025 21:45
Copy link
Owner

@jekalmin jekalmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know your thought!

@brandon-fryslie
Copy link

What does the PR do? Is putting a high-level description in PRs not something that happens any more?

@brandon-fryslie
Copy link

From what I understand the PR is only adding an example to the README?

@thomasgeens thomasgeens changed the title feat(examples): add function to set a fan preset_mode docs(examples): add function to set a fan preset_mode Jun 21, 2025
@thomasgeens
Copy link
Contributor Author

thomasgeens commented Jun 21, 2025

What does the PR do? Is putting a high-level description in PRs not something that happens any more?

As per your friendly request I've added a PR description 😄

@thomasgeens thomasgeens requested a review from jekalmin June 21, 2025 08:31
@jekalmin jekalmin changed the base branch from main to v1.2.1 December 13, 2025 17:00
@jekalmin jekalmin added this to the 1.2.1 milestone Dec 13, 2025
@jekalmin jekalmin merged commit 92242b2 into jekalmin:v1.2.1 Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants