Implement lag delay and extend replay length durations to 12 seconds.#409
Open
Bernie wants to merge 1 commit intojeffpiazza:masterfrom
Open
Implement lag delay and extend replay length durations to 12 seconds.#409Bernie wants to merge 1 commit intojeffpiazza:masterfrom
Bernie wants to merge 1 commit intojeffpiazza:masterfrom
Conversation
Owner
|
I've finally read this through well enough to understand it, and I'm mostly OK with adding this. I think I'd prefer to adopt recording_delay over lag as the name of the variable and element. Happily that matches the explanatory text on the input. Correspondingly, the current "delay" input and variable should probably be renamed playback_delay for symmetry. If you can make those changes, I'd be happy to merge this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a parameter to delay the replay recording by the given duration in seconds. This differs from the delay parameter provided in the replace kiosk in that it actually delays the recording start instead of simply delaying the replay.
This was implemented as we found the "live recording" from the replay kiosk was often a few seconds behind, and in some extreme cases would completely miss the replay by ending before the race actually started in the replay stream.
Fine tuning this parameter helped us to reliably capture the race.
This PR also extends the replay duration options as we found a longer duration would help in ensuring we captured the race.