feat: Add phonetic name support for racers in registration and editing#404
feat: Add phonetic name support for racers in registration and editing#404Japenner wants to merge 1 commit intojeffpiazza:masterfrom
Conversation
There was a problem hiding this comment.
My editor inadvertently blew away formatting here, will fix in a soon to be pushed commit.
There was a problem hiding this comment.
My editor inadvertently blew away formatting here, will fix in a soon to be pushed commit.
There was a problem hiding this comment.
My editor inadvertently blew away formatting here, will fix in a soon to be pushed commit.
There was a problem hiding this comment.
This entire file was reformatted by my editor. Will rectify...and change my local settings. 😅
|
So, the idea here is to be able to capture phonetic spellings for racers' names, and display those instead of the actual correct spellings? I appreciate the details about the code changes, but I think I'd start with what problem this is trying to solve and how this addresses that problem. |
@jeffpiazza Thanks Jeff! Sorry, I was going to update the description more once I had completed the work, I had some free time this morning so I went ahead and built what I could without much communication. This was a feature that was requested by another user but I may have jumped the gun with changes to the primary branch that may just need to stay in a local branch. The problem attempting to be solved is the application is going to be used by an organization hosting a race for multiple different churches in the area. All the newcomers are unknown and the host want's to get pronunciation right off the bat. This view is really only supposed to be viewable to the administrator, so that'll need to be changed regardless of where these changes end up. I'll keep you posted when I get everything sorted. Until then, please disregard this PR as it may not stick around. |
Summary
This pull request adds support for storing and displaying phonetic versions of racers' first and last names throughout the application. The changes include database schema updates, backend logic to handle phonetic names during racer creation, editing, and import, frontend form updates, and new API and display logic to show phonetic names when requested.
Details
Phonetic Name Support
action.racer.add.inc,action.racer.edit.inc,action.racer.import.inc,newracer.inc). [1] [2] [3] [4]PHONETIC_NAMES_SCHEMAto gate phonetic name support based on schema version (schema_version.inc). [1] [2]Frontend and API Enhancements
checkin.php).checkin-table.inc,json-current-racers.inc). [1] [2]now-racing-poller-phonetic.js) to request and display phonetic names for currently racing participants. [1] [2]Name Display Logic
PHONETIC_NAMEand updated themangled_namefunction to use phonetic names if available, falling back to regular names otherwise (name-mangler.inc). [1] [2]