Skip to content

feat: Add phonetic name support for racers in registration and editing#404

Draft
Japenner wants to merge 1 commit intojeffpiazza:masterfrom
Japenner:jap/feat/phonetic-names
Draft

feat: Add phonetic name support for racers in registration and editing#404
Japenner wants to merge 1 commit intojeffpiazza:masterfrom
Japenner:jap/feat/phonetic-names

Conversation

@Japenner
Copy link

Summary

This pull request adds support for storing and displaying phonetic versions of racers' first and last names throughout the application. The changes include database schema updates, backend logic to handle phonetic names during racer creation, editing, and import, frontend form updates, and new API and display logic to show phonetic names when requested.

Details

Phonetic Name Support

  • Added support for phonetic first and last names in racer creation, editing, and import logic, including passing these fields through relevant forms and backend handlers (action.racer.add.inc, action.racer.edit.inc, action.racer.import.inc, newracer.inc). [1] [2] [3] [4]
  • Updated the database schema version and added a new constant PHONETIC_NAMES_SCHEMA to gate phonetic name support based on schema version (schema_version.inc). [1] [2]

Frontend and API Enhancements

  • Extended the check-in form to allow entry of phonetic first and last names (checkin.php).
  • Updated SQL queries and output logic to include phonetic names if supported by the schema (checkin-table.inc, json-current-racers.inc). [1] [2]
  • Added a new poller endpoint and JavaScript poller (now-racing-poller-phonetic.js) to request and display phonetic names for currently racing participants. [1] [2]

Name Display Logic

  • Introduced a new name style constant PHONETIC_NAME and updated the mangled_name function to use phonetic names if available, falling back to regular names otherwise (name-mangler.inc). [1] [2]

@Japenner Japenner marked this pull request as draft January 19, 2026 18:26
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My editor inadvertently blew away formatting here, will fix in a soon to be pushed commit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My editor inadvertently blew away formatting here, will fix in a soon to be pushed commit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My editor inadvertently blew away formatting here, will fix in a soon to be pushed commit.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire file was reformatted by my editor. Will rectify...and change my local settings. 😅

@jeffpiazza
Copy link
Owner

So, the idea here is to be able to capture phonetic spellings for racers' names, and display those instead of the actual correct spellings? I appreciate the details about the code changes, but I think I'd start with what problem this is trying to solve and how this addresses that problem.

@Japenner
Copy link
Author

So, the idea here is to be able to capture phonetic spellings for racers' names, and display those instead of the actual correct spellings? I appreciate the details about the code changes, but I think I'd start with what problem this is trying to solve and how this addresses that problem.

@jeffpiazza Thanks Jeff!

Sorry, I was going to update the description more once I had completed the work, I had some free time this morning so I went ahead and built what I could without much communication.

This was a feature that was requested by another user but I may have jumped the gun with changes to the primary branch that may just need to stay in a local branch.

The problem attempting to be solved is the application is going to be used by an organization hosting a race for multiple different churches in the area. All the newcomers are unknown and the host want's to get pronunciation right off the bat. This view is really only supposed to be viewable to the administrator, so that'll need to be changed regardless of where these changes end up.

I'll keep you posted when I get everything sorted. Until then, please disregard this PR as it may not stick around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments