Skip to content

Using observe-js ObjectObserver instead of Object.observe #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Using observe-js ObjectObserver instead of Object.observe #22

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec48836
Using observe-js ObjectObserver instead of Object.observe
daviddeutsch Jan 12, 2014
4cf6c5e
fixing onObjectObserved to work with ObjectObserver
daviddeutsch Jan 14, 2014
fb60c79
Fixing object removal with ObjectObserver
daviddeutsch Jan 14, 2014
7d9af45
almost forgot: .close() instead of .unobserve()
daviddeutsch Jan 16, 2014
53e5a1c
Merge branch 'master' of github.com:daviddeutsch/omnibinder
daviddeutsch Jan 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/observer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,14 @@ angular.module('OmniBinder')
* the removed and added objects.
*/
this.observeObjectInCollection = function (context, collection, object, callback) {
function onObjectObserved (changes) {
function onObjectObserved(added, removed, changed, getOldValueFn) {
var changes = [{
added: added,
removed: removed,
changed: changed,
index: getOldValueFn(context.key)
}];

/*
An empty array to hold splice objects that will be created.
Splices will look like splices generated natively from Array.observe().
Expand All @@ -109,8 +116,7 @@ angular.module('OmniBinder')
}
}

this.observers[object] = onObjectObserved;
Object.observe(object, onObjectObserved);
this.observers[object] = new ObjectObserver(object, onObjectObserved);
};

/*
Expand Down Expand Up @@ -181,7 +187,7 @@ angular.module('OmniBinder')
if (change.removed.length) {
//Unobserve each item
angular.forEach(change.removed, function unObserve (obj) {
Object.unobserve(obj, self.observers[obj]);
self.observers[obj].close();
});
}
}
Expand Down