Skip to content

Conversation

aguinane
Copy link
Contributor

@aguinane aguinane commented Aug 9, 2024

Resolves issue #432

Copy link
Contributor

mergify bot commented Aug 9, 2024

⚠️ No release notes detected. Please make sure to use reno to add a changelog entry.

@aguinane
Copy link
Contributor Author

Updated with %.3g instead or %0.3f as the default.

@asqui
Copy link
Contributor

asqui commented Aug 15, 2024

This latest change deviates from the default format for after_log():

def after_log(
logger: "logging.Logger",
log_level: int,
sec_format: str = "%0.3f",
) -> typing.Callable[["RetryCallState"], None]:

Should we update that too, so that the two are consistent?

@jd
Copy link
Owner

jd commented Aug 19, 2024

Sounds like a good idea.

@aguinane
Copy link
Contributor Author

Made the change to after_log also.

jd
jd previously approved these changes Aug 20, 2024
@mergify mergify bot dismissed jd’s stale review April 2, 2025 10:04

Pull request has been modified.

@aguinane
Copy link
Contributor Author

aguinane commented Apr 2, 2025

I've re-synced this with main. Anything else that needs to be updated?

@aguinane aguinane requested a review from jd April 2, 2025 10:08
@aguinane aguinane changed the title Apply formatting to num seconds Apply formatting to num seconds in before_sleep_log Apr 2, 2025
@jd jd added the no-changelog No changelog needed label Apr 2, 2025
@mergify mergify bot merged commit 012dc0d into jd:main Apr 2, 2025
10 checks passed
@aguinane aguinane deleted the log-format branch August 29, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No changelog needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants